Messages in this thread | | | Date | Wed, 17 Nov 2021 18:41:38 -0500 | From | Steven Rostedt <> | Subject | Re: [PATCH] tracing: fix va_list breakage in trace_check_vprintf() |
| |
On Wed, 17 Nov 2021 18:38:27 -0500 Steven Rostedt <rostedt@goodmis.org> wrote:
> The real fix is: > > diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c > index f9139dc1262c..7aa5ea5ca912 100644 > --- a/kernel/trace/trace.c > +++ b/kernel/trace/trace.c > @@ -3654,6 +3654,10 @@ static bool trace_safe_str(struct trace_iterator *iter, const char *str) > struct trace_event *trace_event; > struct trace_event_call *event; > > + /* if seq is full, then we can't test it */ > + if (iter->seq->full) > + return true; > + > /* OK if part of the event data */ > if ((addr >= (unsigned long)iter->ent) && > (addr < (unsigned long)iter->ent + iter->ent_size))
BTW, feel free to respin the patch and send a v2 and just add:
Suggested-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
-- Steve
| |