lkml.org 
[lkml]   [2021]   [Nov]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[RFC PATCH v4 net-next 05/23] net: dsa: ocelot: felix: Remove requirement for PCS in felix devices
    Date
    Existing felix devices all have an initialized pcs array. Future devices
    might not, so running a NULL check on the array before dereferencing it
    will allow those future drivers to not crash at this point

    Signed-off-by: Colin Foster <colin.foster@in-advantage.com>
    ---
    drivers/net/dsa/ocelot/felix.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/net/dsa/ocelot/felix.c b/drivers/net/dsa/ocelot/felix.c
    index 327cc4654806..94702042246c 100644
    --- a/drivers/net/dsa/ocelot/felix.c
    +++ b/drivers/net/dsa/ocelot/felix.c
    @@ -820,7 +820,7 @@ static void felix_phylink_mac_config(struct dsa_switch *ds, int port,
    struct felix *felix = ocelot_to_felix(ocelot);
    struct dsa_port *dp = dsa_to_port(ds, port);

    - if (felix->pcs[port])
    + if (felix->pcs && felix->pcs[port])
    phylink_set_pcs(dp->pl, &felix->pcs[port]->pcs);
    }

    --
    2.25.1
    \
     
     \ /
      Last update: 2021-11-16 07:28    [W:3.392 / U:0.104 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site