lkml.org 
[lkml]   [2021]   [Nov]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v16 5/7] usb: Specify dependencies on USB_XHCI_PLATFORM with 'depends on'
On Thu, Nov 11, 2021 at 03:48:06PM -0800, Doug Anderson wrote:
> Hi,
>
> On Fri, Aug 13, 2021 at 12:52 PM Matthias Kaehlcke <mka@chromium.org> wrote:
> >
> > config USB_DWC3
> > tristate "DesignWare USB3 DRD Core Support"
> > - depends on (USB || USB_GADGET) && HAS_DMA
> > - select USB_XHCI_PLATFORM if USB_XHCI_HCD
> > + depends on ((USB && USB_XHCI_PLATFORM) || USB_GADGET) && HAS_DMA
>
> Technically you don't need the "USB &&", right? Since
> USB_XHCI_PLATFORM is defined in 'usb/host/Kconfig' and that's only
> even included if USB is defined. So it can be just:
>
> depends on (USB_XHCI_PLATFORM || USB_GADGET) && HAS_DMA

True, the dependency on USB isn't strictly needed.

> That's not terribly important, though, so:
>
> Reviewed-by: Douglas Anderson <dianders@chromium.org>

Thanks!

\
 
 \ /
  Last update: 2021-11-16 19:09    [W:0.094 / U:0.548 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site