lkml.org 
[lkml]   [2021]   [Nov]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: [PATCH] fs: Eliminate compilation warnings for misc
On Tue, Nov 16, 2021 at 04:06:11PM +0800, Tianjia Zhang wrote:
> Eliminate the following clang compilation warnings by adding or
> fixing function comment:

These warnings have nothing to do with clang. They're produced by
scripts/kernel-doc:

if (show_warnings($type, $declaration_name) && $param !~ /\./) {
print STDERR
"${file}:$.: warning: Function parameter or member '$param' not described in '$declaration_name'\n";
++$warnings;
}

They show up in any W=1 build (which tells you that people are not
checking their patches with W=1)

> +++ b/fs/file.c
> @@ -645,7 +645,7 @@ EXPORT_SYMBOL(close_fd); /* for ksys_close() */
>
> /**
> * last_fd - return last valid index into fd table
> - * @cur_fds: files struct
> + * @fdt: fdtable struct

I don't think the word 'struct' there really conveys any meaning.

\
 
 \ /
  Last update: 2021-11-16 18:19    [W:0.086 / U:0.028 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site