Messages in this thread Patch in this message | | | From | Nathan Chancellor <> | Subject | [PATCH] hwmon: (tmp401) Fix clang -Wimplicit-fallthrough in tmp401_is_visible() | Date | Tue, 16 Nov 2021 08:44:39 -0700 |
| |
Clang warns:
drivers/hwmon/tmp401.c:526:2: error: unannotated fall-through between switch labels [-Werror,-Wimplicit-fallthrough] default: ^ drivers/hwmon/tmp401.c:526:2: note: insert 'break;' to avoid fall-through default: ^ break; 1 error generated.
Clang is a little more pedantic than GCC, which does not warn when falling through to a case that is just break or return. Clang's version is more in line with the kernel's own stance in deprecated.rst, which states that all switch/case blocks must end in either break, fallthrough, continue, goto, or return. Add the missing break to silence the warning.
Link: https://github.com/ClangBuiltLinux/linux/issues/1505 Signed-off-by: Nathan Chancellor <nathan@kernel.org> ---
Feel free to squash this into the offending commit.
drivers/hwmon/tmp401.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/drivers/hwmon/tmp401.c b/drivers/hwmon/tmp401.c index f7b6a2c4fbcf..b86d9df7105d 100644 --- a/drivers/hwmon/tmp401.c +++ b/drivers/hwmon/tmp401.c @@ -523,6 +523,7 @@ static umode_t tmp401_is_visible(const void *data, enum hwmon_sensor_types type, default: break; } + break; default: break; } base-commit: 82b520da9134a594eb9816759ed66ba6ef44888e -- 2.34.0
| |