Messages in this thread | | | Date | Tue, 16 Nov 2021 16:28:34 +0100 | Subject | Re: [PATCH] fw_cfg: Fix memory leak in fw_cfg_register_file | From | Philippe Mathieu-Daudé <> |
| |
On 11/16/21 12:42, Miaoqian Lin wrote: > When kobject_init_and_add() fails, entry should be freed just like > when sysfs_create_bin_file() fails. >
Fixes: fe3c60684377 ("firmware: Fix a reference count leak.") Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> Signed-off-by: Miaoqian Lin <linmq006@gmail.com> > --- > drivers/firmware/qemu_fw_cfg.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/firmware/qemu_fw_cfg.c b/drivers/firmware/qemu_fw_cfg.c > index 172c751a4f6c..0f404777f016 100644 > --- a/drivers/firmware/qemu_fw_cfg.c > +++ b/drivers/firmware/qemu_fw_cfg.c > @@ -608,6 +608,7 @@ static int fw_cfg_register_file(const struct fw_cfg_file *f) > fw_cfg_sel_ko, "%d", entry->select); > if (err) { > kobject_put(&entry->kobj); > + kfree(entry); > return err; > } > >
| |