Messages in this thread | | | Date | Tue, 16 Nov 2021 16:20:28 +0100 | From | Nicolas Toromanoff <> | Subject | Re: [PATCH v2 7/8] crypto: stm32/cryp - fix bugs and crash in tests |
| |
Hello,
> +static void stm32_cryp_write_ccm_first_header(struct stm32_cryp *cryp) > +{ > [...] > + } else { > + /* Build the two first u32 of B1 */ > + b8[0] = 0xFF; > + b8[1] = 0xFE; > + b8[2] = alen & 0xFF000000 >> 24; > + b8[3] = alen & 0x00FF0000 >> 16; > + b8[4] = alen & 0x0000FF00 >> 8;
Smatch found a bug here: "warn: shift has higher precedence than mask"
Regards, Nicolas.
| |