[lkml]   [2021]   [Nov]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
Subject[PATCH v9 0/5] Add Xilinx AMS Driver
Add Xilinx AMS driver which is used for Xilinx's ZynqMP AMS controller.
This AMS driver is used to report various interface voltages and temperatures
across the system.
This driver will be used by iio-hwmon to repport voltages and temperatures
across the system by using various channel interfaces.
This driver handles AMS module including PS-Sysmon & PL-Sysmon. The binding
documentation is added for understanding of AMS, PS, PL Sysmon Channels.

Changes in v2:
- Added documentation for sysfs (Patch-2)
- Addressed code style review comments
- Patch-2 (Now it is Patch-3)
- Arranged the includes in alphabetical order
- Removed the wrapper 'ams_pl_write_reg()' and used writel
- Removed the unnecessary delay of 1ms and used polling of EOC
- Removed spin_lock and used mutex only.
- Used request_irq() instead of devm_request_irq() and handled
respective error conditions
- Moved contents of xilinx-ams.h to inline with xilinx-ams.c
- Patch-1
- Addressed Documentation style comments

Changes in v3:
- Updated bindings document with the suggested modification in v2 review
- Removed documentation for sysfs
- Removed extended names for channels in the Xilinx AMS driver
- Modified dts to use ranges for child nodes
- Reduced address and size cells to 32-bit instead of 64-bit

Changes in v4:
- Updated bindings document with the suggested modification in v3 review
- Changed the Device Tree property 'ranges' for child nodes
- Used Channel Numbers as 'reg' value in DT to avoid confusion
- Removed unused NULL arguments as suggested in v3 patch review
- Addressed comments on Device Tree property naming

Changes in v5:
- Updated bindings document to the YAML format
- Updated bindings document with the suggested modification in v4 review
- Renamed iio_pl_info struct to iio_ams_info in Xilinx AMS driver
- Updated the Xilinx AMS driver to not use iio_priv_to_dev function
- Updated Xilinx AMS node to reflect the changes in bindings document
- Update MAINTAINERS file

Changes in v6:
- Removed all tabs from bindings document.
- Removed the xlnx,ext-channels node from the device tree since
it is not neeeded.
- Fixed unit addresses for ps-ams and pl-ams.
- Removed the names property from bindings.
- Fixed warnings from in the driver.
- devm_add_action_or_reset() used for exit/error path.
- devm_request_irq() for managed irq request instead of

Changes in v7:
- Added use of FIELD_PREP and FIELD_GET.
- Added the spinlocks back the v1 which were removed in v2 for
no justifiable reason and replaced with the same mutex. This
caused deadlocks.
- Removed the buffered mode information from channel config.
- Usage of wrapper functions for devm_add_action_or_reset
callbacks to avoid typecasting functions.
- Usage of devm_platform_iremap_resource().
- Handled platform_get_irq() return values.
- Removed the remove() callback.
- Fixed the dt-bindings.

Changes in v8:
- Replaced *_of_() APIs with fwnode.
- Added missing headers.
- Fixed documentation.
- Added devm_add_action_or_reset() for iounmap.
- Restructured read_raw function.
- Added helper functions.
- Usage of GENMASK for all masks.
- Added defaults for most switch cases. Some can't be added
since the default will never occur.

Changes in v9:
- Added a fwnode_iomap().
- Fixed Kconfig indentation.
- Added the overflow checks before memory allocation.
- Usage of fwnode_iomap() instead of iomap().
- Rename ams_parse_dt() to ams_parse_firmware().

Anand Ashok Dumbre (5):
device property: Add fwnode_iomap()
arm64: zynqmp: DT: Add Xilinx AMS node
iio: adc: Add Xilinx AMS driver
dt-bindings: iio: adc: Add Xilinx AMS binding documentation
MAINTAINERS: Add maintainer for xilinx-ams

.../bindings/iio/adc/xlnx,zynqmp-ams.yaml | 227 +++
arch/arm64/boot/dts/xilinx/zynqmp.dtsi | 26 +-
drivers/base/property.c | 16 +
drivers/iio/adc/Kconfig | 15 +
drivers/iio/adc/Makefile | 1 +
drivers/iio/adc/xilinx-ams.c | 1456 +++++++++++++++++
include/linux/property.h | 2 +
8 files changed, 1749 insertions(+), 1 deletion(-)
create mode 100644 Documentation/devicetree/bindings/iio/adc/xlnx,zynqmp-ams.yaml
create mode 100644 drivers/iio/adc/xilinx-ams.c


 \ /
  Last update: 2021-11-16 16:11    [W:0.163 / U:28.428 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site