Messages in this thread | | | Date | Tue, 16 Nov 2021 15:55:46 +0100 | Subject | Re: [PATCH] xen/privcmd: make option visible in Kconfig | From | Jan Beulich <> |
| |
On 16.11.2021 15:33, Juergen Gross wrote: > This configuration option provides a misc device as an API to userspace. > Make this API usable without having to select the module as a transitive > dependency. > > This also fixes an issue where localyesconfig would select > CONFIG_XEN_PRIVCMD=m because it was not visible and defaulted to > building as module. > > Based-on-patch-by: Thomas Weißschuh <linux@weissschuh.net> > Signed-off-by: Juergen Gross <jgross@suse.com>
Reviewed-by: Jan Beulich <jbeulich@suse.com>
> --- a/drivers/xen/Kconfig > +++ b/drivers/xen/Kconfig > @@ -259,9 +259,14 @@ config XEN_SCSI_BACKEND > if guests need generic access to SCSI devices. > > config XEN_PRIVCMD > - tristate > + tristate "Xen hypercall passthrough driver" > depends on XEN > default m > + help > + The hypercall passthrough driver allows user land programs to perform
Maybe worth adding "privileged" here? Albeit of course that's different from the use of the word ...
> + Xen hypercalls. This driver is normally required for systems running > + as Dom0 to perform privileged operations, but in some disaggregated
... here, so there'd be a small risk of confusion.
Jan
> + Xen setups this driver might be needed for other domains, too. > > config XEN_ACPI_PROCESSOR > tristate "Xen ACPI processor" >
| |