lkml.org 
[lkml]   [2021]   [Nov]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 06/13] dmaengine: at_xdmac: Fix concurrency over chan's completed_cookie
    Date
    Caller of dma_cookie_complete is expected to hold a lock to prevent
    concurrency over the channel's completed cookie marker.

    Fixes: e1f7c9eee707 ("dmaengine: at_xdmac: creation of the atmel eXtended DMA Controller driver")
    Signed-off-by: Tudor Ambarus <tudor.ambarus@microchip.com>
    ---
    drivers/dma/at_xdmac.c | 3 +--
    1 file changed, 1 insertion(+), 2 deletions(-)

    diff --git a/drivers/dma/at_xdmac.c b/drivers/dma/at_xdmac.c
    index b45ae4fee9db..4d8476845c20 100644
    --- a/drivers/dma/at_xdmac.c
    +++ b/drivers/dma/at_xdmac.c
    @@ -1703,11 +1703,10 @@ static void at_xdmac_tasklet(struct tasklet_struct *t)
    }

    txd = &desc->tx_dma_desc;
    -
    + dma_cookie_complete(txd);
    at_xdmac_remove_xfer(atchan, desc);
    spin_unlock_irq(&atchan->lock);

    - dma_cookie_complete(txd);
    if (txd->flags & DMA_PREP_INTERRUPT)
    dmaengine_desc_get_callback_invoke(txd, NULL);

    --
    2.25.1
    \
     
     \ /
      Last update: 2021-11-16 12:23    [W:4.352 / U:0.480 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site