Messages in this thread | | | Date | Tue, 16 Nov 2021 10:05:56 +0100 | Subject | Re: [PATCH] memory: tegra20-emc: Remove unnecessary print function dev_err() | From | Krzysztof Kozlowski <> |
| |
On 16/11/2021 02:39, Xu Wang wrote: > The print function dev_err() is redundant because > platform_get_irq() already prints an error. > > Signed-off-by: Xu Wang <vulab@iscas.ac.cn> > --- > drivers/memory/tegra/tegra20-emc.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/memory/tegra/tegra20-emc.c b/drivers/memory/tegra/tegra20-emc.c > index 497b6edbf3ca..b2107d16570e 100644 > --- a/drivers/memory/tegra/tegra20-emc.c > +++ b/drivers/memory/tegra/tegra20-emc.c > @@ -1207,10 +1207,8 @@ static int tegra_emc_probe(struct platform_device *pdev) > int irq, err; > > irq = platform_get_irq(pdev, 0); > - if (irq < 0) { > - dev_err(&pdev->dev, "please update your device tree\n"); > + if (irq < 0) > return irq; > - }
No, it's not redundant because it is a different error message.
Best regards, Krzysztof
| |