lkml.org 
[lkml]   [2021]   [Nov]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] gpio/rockchip: needs GENERIC_IRQ_CHIP to fix build errors
On Tue, Nov 16, 2021 at 7:46 AM Randy Dunlap <rdunlap@infradead.org> wrote:
>
> gpio-rockchip uses interfaces that are provided by the Kconfig
> symbol GENERIC_IRQ_CHIP, so the driver should select that symbol
> in order to prevent build errors.
>
> Fixes these build errors (and more):
>
> aarch64-linux-ld: drivers/gpio/gpio-rockchip.o: in function `rockchip_irq_disable':
> gpio-rockchip.c:(.text+0x454): undefined reference to `irq_gc_mask_set_bit'
> aarch64-linux-ld: drivers/gpio/gpio-rockchip.o: in function `rockchip_irq_enable':
> gpio-rockchip.c:(.text+0x478): undefined reference to `irq_gc_mask_clr_bit'
> aarch64-linux-ld: drivers/gpio/gpio-rockchip.o: in function `rockchip_interrupts_register':
> gpio-rockchip.c:(.text+0x518): undefined reference to `irq_generic_chip_ops'
> aarch64-linux-ld: gpio-rockchip.c:(.text+0x594): undefined reference to `__irq_alloc_domain_generic_chips'
> aarch64-linux-ld: gpio-rockchip.c:(.text+0x5cc): undefined reference to `irq_get_domain_generic_chip'
> aarch64-linux-ld: gpio-rockchip.c:(.text+0x5e0): undefined reference to `irq_gc_ack_set_bit'
> aarch64-linux-ld: gpio-rockchip.c:(.text+0x604): undefined reference to `irq_gc_set_wake'
>
> Fixes: 936ee2675eee ("gpio/rockchip: add driver for rockchip gpio")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Reported-by: kernel test robot <lkp@intel.com>
> ---
> drivers/gpio/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> --- linux-next-20211116.orig/drivers/gpio/Kconfig
> +++ linux-next-20211116/drivers/gpio/Kconfig
> @@ -523,6 +523,7 @@ config GPIO_REG
> config GPIO_ROCKCHIP
> tristate "Rockchip GPIO support"
> depends on ARCH_ROCKCHIP || COMPILE_TEST
> + select GENERIC_IRQ_CHIP
> select GPIOLIB_IRQCHIP
> default ARCH_ROCKCHIP
> help

Applied for fixes, thanks!

Bart

\
 
 \ /
  Last update: 2021-11-16 09:43    [W:0.036 / U:0.044 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site