Messages in this thread | | | Date | Tue, 16 Nov 2021 08:15:30 +0100 | From | Marc Kleine-Budde <> | Subject | Re: [PATCH net 1/4] can: m_can: pci: fix incorrect reference clock rate |
| |
On 16.11.2021 09:11:40, Jarkko Nikula wrote: > > ip link set can0 type can bitrate 1000000 dbitrate 2000000 fd on > > I got confirmation the clock to CAN controller is indeed changed from 100 > MHz to 200 MHz in release HW & firmware. > > I haven't upgraded the FW in a while on our HW so that perhaps explain > why I was seeing expected rate :-)
Can we query the FW version in the driver and set the clock rate accordingly?
> So which one is more appropriate: > > Acked-by: Jarkko Nikula <jarkko.nikula@linux.intel.com> > or > Reviewed-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
regards, Marc
-- Pengutronix e.K. | Marc Kleine-Budde | Embedded Linux | https://www.pengutronix.de | Vertretung West/Dortmund | Phone: +49-231-2826-924 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | [unhandled content-type:application/pgp-signature] | |