lkml.org 
[lkml]   [2021]   [Nov]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/3] serial: liteuart: fix use-after-free and memleak on unbind
On Tue, Nov 16, 2021 at 06:15:05AM +0900, Stafford Horne wrote:
> On Mon, Nov 15, 2021 at 02:37:44PM +0100, Johan Hovold wrote:
> > Deregister the port when unbinding the driver to prevent it from being
> > used after releasing the driver data and leaking memory allocated by
> > serial core.
>
> This looks good to me. Just curious did you test this on a Litex
> SoC/FPGA?

No, this series has only been compile tested.

> > Fixes: 1da81e5562fa ("drivers/tty/serial: add LiteUART driver")
> > Cc: stable@vger.kernel.org # 5.11
> > Cc: Filip Kokosinski <fkokosinski@antmicro.com>
> > Cc: Mateusz Holenko <mholenko@antmicro.com>
> > Cc: Stafford Horne <shorne@gmail.com>
> > Signed-off-by: Johan Hovold <johan@kernel.org>
>
> Reviewed-by: Stafford Horne <shorne@gmail.com>

Thanks for reviewing.

Johan

\
 
 \ /
  Last update: 2021-11-16 08:07    [W:1.357 / U:0.004 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site