lkml.org 
[lkml]   [2021]   [Nov]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 1/2] tracing: Add helper functions to simplify event_command callback handling
On Fri, 12 Nov 2021 14:23:39 -0600
Tom Zanussi <zanussi@kernel.org> wrote:

>
> +int event_trigger_check(char *glob, char **trigger, char **param,
> + bool *remove, bool require_param, bool separate_trigger)

All these functions are going to require having kerneldoc comments for
them. I rather not have to try to figure out what these functions are for
and just read the documentation.

-- Steve


> +{
> + int ret = 0;
> +
> + *remove = (glob && glob[0] == '!') ? true : false;
> +

\
 
 \ /
  Last update: 2021-11-16 22:41    [W:0.045 / U:0.200 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site