Messages in this thread | | | From | Marco Elver <> | Date | Mon, 15 Nov 2021 15:40:24 +0100 | Subject | Re: [PATCH] panic: use error_report_end tracepoint on warnings |
| |
On Mon, 15 Nov 2021 at 15:38, Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote: > > On Mon, Nov 15, 2021 at 09:56:30AM +0100, Marco Elver wrote: > > Introduce the error detector "warning" to the error_report event and use > > the error_report_end tracepoint at the end of a warning report. > > > > This allows in-kernel tests but also userspace to more easily determine > > if a warning occurred without polling kernel logs. > > ... > > > enum error_detector { > > ERROR_DETECTOR_KFENCE, > > - ERROR_DETECTOR_KASAN > > + ERROR_DETECTOR_KASAN, > > + ERROR_DETECTOR_WARN > > ...which exactly shows my point (given many times somewhere else) why comma > is good to have when we are not sure the item is a terminator one in the enum > or array of elements.
So you want me to add a comma?
(I'm not participating in bikeshedding here, just tell me what to do.)
Thanks, -- Marco
| |