Messages in this thread Patch in this message | | | From | Johan Hovold <> | Subject | [PATCH 2/3] serial: liteuart: fix use-after-free and memleak on unbind | Date | Mon, 15 Nov 2021 14:37:44 +0100 |
| |
Deregister the port when unbinding the driver to prevent it from being used after releasing the driver data and leaking memory allocated by serial core.
Fixes: 1da81e5562fa ("drivers/tty/serial: add LiteUART driver") Cc: stable@vger.kernel.org # 5.11 Cc: Filip Kokosinski <fkokosinski@antmicro.com> Cc: Mateusz Holenko <mholenko@antmicro.com> Cc: Stafford Horne <shorne@gmail.com> Signed-off-by: Johan Hovold <johan@kernel.org> --- drivers/tty/serial/liteuart.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/drivers/tty/serial/liteuart.c b/drivers/tty/serial/liteuart.c index f075f4ff5fcf..da792d0df790 100644 --- a/drivers/tty/serial/liteuart.c +++ b/drivers/tty/serial/liteuart.c @@ -295,6 +295,7 @@ static int liteuart_remove(struct platform_device *pdev) struct uart_port *port = platform_get_drvdata(pdev); struct liteuart_port *uart = to_liteuart_port(port); + uart_remove_one_port(&liteuart_driver, port); xa_erase(&liteuart_array, uart->id); return 0; -- 2.32.0
| |