lkml.org 
[lkml]   [2021]   [Nov]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v1 1/3] media: staging: tegra-vde: Support reference picture marking
On Mon, Nov 15, 2021 at 01:34:18AM +0300, Dmitry Osipenko wrote:
> 15.11.2021 01:23, Dmitry Osipenko пишет:
> > + vde->secure_bo = tegra_vde_alloc_bo(vde, DMA_FROM_DEVICE, 4096);
> > + if (!vde->secure_bo) {
> > + dev_err(dev, "Failed to allocate secure BO\n");
> > + goto err_pm_runtime;
> > + }
>
> My eye just caught that by accident err variable isn't assigned to
> -ENOMEM here. I'll make v2 shortly.

Smatch has a check for this so we would have caught it. :)

regards,
dan carpenter

\
 
 \ /
  Last update: 2021-11-15 13:44    [W:0.092 / U:16.000 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site