lkml.org 
[lkml]   [2021]   [Nov]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 466/575] power: supply: bq27xxx: Fix kernel crash on IRQ handler register error
    Date
    From: Hans de Goede <hdegoede@redhat.com>

    [ Upstream commit cdf10ffe8f626d8a2edc354abf063df0078b2d71 ]

    When registering the IRQ handler fails, do not just return the error code,
    this will free the devm_kzalloc()-ed data struct while leaving the queued
    work queued and the registered power_supply registered with both of them
    now pointing to free-ed memory, resulting in various kernel crashes
    soon afterwards.

    Instead properly tear-down things on IRQ handler register errors.

    Fixes: 703df6c09795 ("power: bq27xxx_battery: Reorganize I2C into a module")
    Cc: Andrew F. Davis <afd@ti.com>
    Signed-off-by: Hans de Goede <hdegoede@redhat.com>
    Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
    Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/power/supply/bq27xxx_battery_i2c.c | 3 ++-
    1 file changed, 2 insertions(+), 1 deletion(-)

    diff --git a/drivers/power/supply/bq27xxx_battery_i2c.c b/drivers/power/supply/bq27xxx_battery_i2c.c
    index eb4f4284982fa..3012eb13a08cb 100644
    --- a/drivers/power/supply/bq27xxx_battery_i2c.c
    +++ b/drivers/power/supply/bq27xxx_battery_i2c.c
    @@ -187,7 +187,8 @@ static int bq27xxx_battery_i2c_probe(struct i2c_client *client,
    dev_err(&client->dev,
    "Unable to register IRQ %d error %d\n",
    client->irq, ret);
    - return ret;
    + bq27xxx_battery_teardown(di);
    + goto err_failed;
    }
    }

    --
    2.33.0


    \
     
     \ /
      Last update: 2022-09-17 16:12    [W:4.016 / U:0.176 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site