lkml.org 
[lkml]   [2021]   [Nov]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH v8 2/3] dt-bindings: remoteproc: qcom: Add SC7280 WPSS support
    Quoting Rakesh Pillai (2021-11-02 06:44:32)
    > Add WPSS PIL loading support for SC7280 SoCs.
    >
    > Signed-off-by: Rakesh Pillai <pillair@codeaurora.org>
    > ---

    One question

    Reviewed-by: Stephen Boyd <swboyd@chromium.org>

    > .../bindings/remoteproc/qcom,sc7280-wpss-pil.yaml | 217 +++++++++++++++++++++
    > 1 file changed, 217 insertions(+)
    > create mode 100644 Documentation/devicetree/bindings/remoteproc/qcom,sc7280-wpss-pil.yaml
    >
    > diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,sc7280-wpss-pil.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,sc7280-wpss-pil.yaml
    > new file mode 100644
    > index 0000000..eaf7dd1
    > --- /dev/null
    > +++ b/Documentation/devicetree/bindings/remoteproc/qcom,sc7280-wpss-pil.yaml
    > @@ -0,0 +1,217 @@
    > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
    > +%YAML 1.2
    > +---
    > +$id: http://devicetree.org/schemas/remoteproc/qcom,sc7280-wpss-pil.yaml#
    > +$schema: http://devicetree.org/meta-schemas/core.yaml#
    > +
    > +title: Qualcomm SC7280 WPSS Peripheral Image Loader
    > +
    > +maintainers:
    [...]
    > +
    > + glink-edge:
    > + type: object
    > + description: |
    > + Qualcomm G-Link subnode which represents communication edge, channels
    > + and devices related to the ADSP.
    > +
    > + properties:
    > + interrupts:
    > + items:
    > + - description: IRQ from WPSS to GLINK
    > +
    > + mboxes:
    > + items:
    > + - description: Mailbox for communication between APPS and WPSS
    > +
    > + label:
    > + description: The names of the state bits used for SMP2P output
    > + items:
    > + - const: wpss
    > +
    > + qcom,remote-pid:
    > + $ref: /schemas/types.yaml#/definitions/uint32
    > + description: ID of the shared memory used by GLINK for communication with WPSS
    > + maxItems: 1
    > +
    > + required:
    > + - interrupts
    > + - mboxes
    > + - label
    > + - qcom,remote-pid

    Add additionalProperties: false here too?

    \
     
     \ /
      Last update: 2021-11-16 04:11    [W:2.577 / U:1.136 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site