Messages in this thread Patch in this message | | | From | 赵军奎 <> | Subject | 答复: [PATCH] drm/amd/amdgpu: cleanup the c ode style a bit | Date | Mon, 15 Nov 2021 12:01:48 +0000 |
| |
-----邮件原件----- 发件人: bernard@vivo.com <bernard@vivo.com> 代表 Christian K?nig 发送时间: 2021年11月15日 19:49 收件人: 赵军奎 <bernard@vivo.com>; Alex Deucher <alexander.deucher@amd.com>; Christian König <christian.koenig@amd.com>; Pan, Xinhui <Xinhui.Pan@amd.com>; David Airlie <airlied@linux.ie>; Daniel Vetter <daniel@ffwll.ch>; Jingwen Chen <Jingwen.Chen2@amd.com>; Candice Li <candice.li@amd.com>; John Clements <john.clements@amd.com>; Monk liu <monk.liu@amd.com>; Peng Ju Zhou <PengJu.Zhou@amd.com>; Jiawei Gu <Jiawei.Gu@amd.com>; Bokun Zhang <bokun.zhang@amd.com>; Zhigang Luo <zhigang.luo@amd.com>; Lee Jones <lee.jones@linaro.org>; amd-gfx@lists.freedesktop.org; dri-devel@lists.freedesktop.org; linux-kernel@vger.kernel.org 主题: Re: [PATCH] drm/amd/amdgpu: cleanup the code style a bit
Am 15.11.21 um 08:07 schrieb Bernard Zhao: > This change is to cleanup the code style a bit.
>To be honest I think the old style looked better. It took me a moment to validate this now.
>What you could to instead is to have goto style error handling which would make this a bit more cleaner I think. Hi Looks like a good idea, thank you for your comments! I will resubmit a version! BR//Bernard
>Christian.
> > Signed-off-by: Bernard Zhao <bernard@vivo.com> > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c | 10 ++++++---- > 1 file changed, 6 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c > b/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c > index 04cf9b207e62..90070b41136a 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c > @@ -286,12 +286,14 @@ static int amdgpu_virt_init_ras_err_handler_data(struct amdgpu_device *adev) > return -ENOMEM; > > bps = kmalloc_array(align_space, sizeof((*data)->bps), GFP_KERNEL); > + if (!bps) { > + kfree(*data); > + return -ENOMEM; > + } > bps_bo = kmalloc_array(align_space, sizeof((*data)->bps_bo), > GFP_KERNEL); > - > - if (!bps || !bps_bo) { > - kfree(bps); > - kfree(bps_bo); > + if (!bps_bo) { > kfree(*data); > + kfree(bps); > return -ENOMEM; > } >
| |