lkml.org 
[lkml]   [2021]   [Nov]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.14 062/849] net: mscc: ocelot: Add of_node_put() before goto
    Date
    From: Wan Jiabing <wanjiabing@vivo.com>

    [ Upstream commit d1a7b9e4696584ce05c12567762c18a866837a85 ]

    Fix following coccicheck warning:
    ./drivers/net/ethernet/mscc/ocelot_vsc7514.c:946:1-33: WARNING: Function
    for_each_available_child_of_node should have of_node_put() before goto.

    Early exits from for_each_available_child_of_node should decrement the
    node reference counter.

    Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/net/ethernet/mscc/ocelot_vsc7514.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/drivers/net/ethernet/mscc/ocelot_vsc7514.c b/drivers/net/ethernet/mscc/ocelot_vsc7514.c
    index 4bd7e9d9ec61c..03cfa0dc7bf99 100644
    --- a/drivers/net/ethernet/mscc/ocelot_vsc7514.c
    +++ b/drivers/net/ethernet/mscc/ocelot_vsc7514.c
    @@ -972,6 +972,7 @@ static int mscc_ocelot_init_ports(struct platform_device *pdev,
    target = ocelot_regmap_init(ocelot, res);
    if (IS_ERR(target)) {
    err = PTR_ERR(target);
    + of_node_put(portnp);
    goto out_teardown;
    }

    --
    2.33.0


    \
     
     \ /
      Last update: 2021-11-16 03:11    [W:2.869 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site