lkml.org 
[lkml]   [2021]   [Nov]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 202/575] media: rcar-csi2: Add checking to rcsi2_start_receiver()
    Date
    From: Nadezda Lutovinova <lutovinova@ispras.ru>

    [ Upstream commit fc41665498332ad394b7db37f23e9394096ddc71 ]

    If rcsi2_code_to_fmt() return NULL, then null pointer dereference occurs
    in the next cycle. That should not be possible now but adding checking
    protects from future bugs.
    The patch adds checking if format is NULL.

    Found by Linux Driver Verification project (linuxtesting.org).

    Signed-off-by: Nadezda Lutovinova <lutovinova@ispras.ru>
    Reviewed-by: Jacopo Mondi <jacopo@jmondi.org>
    Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
    Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
    Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/media/platform/rcar-vin/rcar-csi2.c | 2 ++
    1 file changed, 2 insertions(+)

    diff --git a/drivers/media/platform/rcar-vin/rcar-csi2.c b/drivers/media/platform/rcar-vin/rcar-csi2.c
    index 79f229756805e..d2d87a204e918 100644
    --- a/drivers/media/platform/rcar-vin/rcar-csi2.c
    +++ b/drivers/media/platform/rcar-vin/rcar-csi2.c
    @@ -544,6 +544,8 @@ static int rcsi2_start_receiver(struct rcar_csi2 *priv)

    /* Code is validated in set_fmt. */
    format = rcsi2_code_to_fmt(priv->mf.code);
    + if (!format)
    + return -EINVAL;

    /*
    * Enable all supported CSI-2 channels with virtual channel and
    --
    2.33.0


    \
     
     \ /
      Last update: 2021-11-16 03:09    [W:2.759 / U:0.156 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site