lkml.org 
[lkml]   [2021]   [Nov]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 378/575] selftests/bpf: Fix fclose/pclose mismatch in test_progs
    Date
    From: Andrea Righi <andrea.righi@canonical.com>

    [ Upstream commit f48ad69097fe79d1de13c4d8fef556d4c11c5e68 ]

    Make sure to use pclose() to properly close the pipe opened by popen().

    Fixes: 81f77fd0deeb ("bpf: add selftest for stackmap with BPF_F_STACK_BUILD_ID")
    Signed-off-by: Andrea Righi <andrea.righi@canonical.com>
    Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
    Reviewed-by: Shuah Khan <skhan@linuxfoundation.org>
    Acked-by: Martin KaFai Lau <kafai@fb.com>
    Link: https://lore.kernel.org/bpf/20211026143409.42666-1-andrea.righi@canonical.com
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    tools/testing/selftests/bpf/test_progs.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    diff --git a/tools/testing/selftests/bpf/test_progs.c b/tools/testing/selftests/bpf/test_progs.c
    index 22943b58d752a..4a13477aef9dd 100644
    --- a/tools/testing/selftests/bpf/test_progs.c
    +++ b/tools/testing/selftests/bpf/test_progs.c
    @@ -347,7 +347,7 @@ int extract_build_id(char *build_id, size_t size)

    if (getline(&line, &len, fp) == -1)
    goto err;
    - fclose(fp);
    + pclose(fp);

    if (len > size)
    len = size;
    @@ -356,7 +356,7 @@ int extract_build_id(char *build_id, size_t size)
    free(line);
    return 0;
    err:
    - fclose(fp);
    + pclose(fp);
    return -1;
    }

    --
    2.33.0


    \
     
     \ /
      Last update: 2021-11-16 03:03    [W:3.103 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site