lkml.org 
[lkml]   [2021]   [Nov]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 257/575] erofs: dont trigger WARN() when decompression fails
    Date
    From: Gao Xiang <hsiangkao@linux.alibaba.com>

    [ Upstream commit a0961f351d82d43ab0b845304caa235dfe249ae9 ]

    syzbot reported a WARNING [1] due to corrupted compressed data.

    As Dmitry said, "If this is not a kernel bug, then the code should
    not use WARN. WARN if for kernel bugs and is recognized as such by
    all testing systems and humans."

    [1] https://lore.kernel.org/r/000000000000b3586105cf0ff45e@google.com

    Link: https://lore.kernel.org/r/20211025074311.130395-1-hsiangkao@linux.alibaba.com
    Cc: Dmitry Vyukov <dvyukov@google.com>
    Reviewed-by: Chao Yu <chao@kernel.org>
    Reported-by: syzbot+d8aaffc3719597e8cfb4@syzkaller.appspotmail.com
    Signed-off-by: Gao Xiang <hsiangkao@linux.alibaba.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    fs/erofs/decompressor.c | 1 -
    1 file changed, 1 deletion(-)

    diff --git a/fs/erofs/decompressor.c b/fs/erofs/decompressor.c
    index cbadbf55c6c20..8a6260aac26cb 100644
    --- a/fs/erofs/decompressor.c
    +++ b/fs/erofs/decompressor.c
    @@ -170,7 +170,6 @@ static int z_erofs_lz4_decompress(struct z_erofs_decompress_req *rq, u8 *out)
    erofs_err(rq->sb, "failed to decompress %d in[%u, %u] out[%u]",
    ret, inlen, inputmargin, rq->outputsize);

    - WARN_ON(1);
    print_hex_dump(KERN_DEBUG, "[ in]: ", DUMP_PREFIX_OFFSET,
    16, 1, src + inputmargin, inlen, true);
    print_hex_dump(KERN_DEBUG, "[out]: ", DUMP_PREFIX_OFFSET,
    --
    2.33.0


    \
     
     \ /
      Last update: 2021-11-16 03:03    [W:2.311 / U:0.188 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site