lkml.org 
[lkml]   [2021]   [Nov]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.14 064/849] scsi: qla2xxx: Return -ENOMEM if kzalloc() fails
    Date
    From: Zheyu Ma <zheyuma97@gmail.com>

    [ Upstream commit 06634d5b6e923ed0d4772aba8def5a618f44c7fe ]

    The driver probing function should return < 0 for failure, otherwise
    kernel will treat value > 0 as success.

    Link: https://lore.kernel.org/r/1634522181-31166-1-git-send-email-zheyuma97@gmail.com
    Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>
    Signed-off-by: Zheyu Ma <zheyuma97@gmail.com>
    Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/scsi/qla2xxx/qla_os.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/scsi/qla2xxx/qla_os.c b/drivers/scsi/qla2xxx/qla_os.c
    index 0d25d2baa35e7..b48d2344fd4ce 100644
    --- a/drivers/scsi/qla2xxx/qla_os.c
    +++ b/drivers/scsi/qla2xxx/qla_os.c
    @@ -4073,7 +4073,7 @@ qla2x00_mem_alloc(struct qla_hw_data *ha, uint16_t req_len, uint16_t rsp_len,
    ql_dbg_pci(ql_dbg_init, ha->pdev,
    0xe0ee, "%s: failed alloc dsd\n",
    __func__);
    - return 1;
    + return -ENOMEM;
    }
    ha->dif_bundle_kallocs++;

    --
    2.33.0


    \
     
     \ /
      Last update: 2021-11-16 02:47    [W:2.337 / U:0.264 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site