lkml.org 
[lkml]   [2021]   [Nov]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.14 147/849] soc: fsl: dpio: replace smp_processor_id with raw_smp_processor_id
    Date
    From: Meng Li <Meng.Li@windriver.com>

    commit e775eb9fc2a4107f03222fa48bc95c2c82427e64 upstream.

    When enable debug kernel configs,there will be calltrace as below:

    BUG: using smp_processor_id() in preemptible [00000000] code: swapper/0/1
    caller is debug_smp_processor_id+0x20/0x30
    CPU: 6 PID: 1 Comm: swapper/0 Not tainted 5.10.63-yocto-standard #1
    Hardware name: NXP Layerscape LX2160ARDB (DT)
    Call trace:
    dump_backtrace+0x0/0x1a0
    show_stack+0x24/0x30
    dump_stack+0xf0/0x13c
    check_preemption_disabled+0x100/0x110
    debug_smp_processor_id+0x20/0x30
    dpaa2_io_query_fq_count+0xdc/0x154
    dpaa2_eth_stop+0x144/0x314
    __dev_close_many+0xdc/0x160
    __dev_change_flags+0xe8/0x220
    dev_change_flags+0x30/0x70
    ic_close_devs+0x50/0x78
    ip_auto_config+0xed0/0xf10
    do_one_initcall+0xac/0x460
    kernel_init_freeable+0x30c/0x378
    kernel_init+0x20/0x128
    ret_from_fork+0x10/0x38

    Based on comment in the context, it doesn't matter whether
    preemption is disable or not. So, replace smp_processor_id()
    with raw_smp_processor_id() to avoid above call trace.

    Fixes: c89105c9b390 ("staging: fsl-mc: Move DPIO from staging to drivers/soc/fsl")
    Cc: stable@vger.kernel.org
    Signed-off-by: Meng Li <Meng.Li@windriver.com>
    Signed-off-by: Li Yang <leoyang.li@nxp.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/soc/fsl/dpio/dpio-service.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/soc/fsl/dpio/dpio-service.c
    +++ b/drivers/soc/fsl/dpio/dpio-service.c
    @@ -59,7 +59,7 @@ static inline struct dpaa2_io *service_s
    * potentially being migrated away.
    */
    if (cpu < 0)
    - cpu = smp_processor_id();
    + cpu = raw_smp_processor_id();

    /* If a specific cpu was requested, pick it up immediately */
    return dpio_by_cpu[cpu];

    \
     
     \ /
      Last update: 2021-11-16 02:45    [W:3.333 / U:1.340 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site