lkml.org 
[lkml]   [2021]   [Nov]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.14 633/849] soc: qcom: apr: Add of_node_put() before return
    Date
    From: Wan Jiabing <wanjiabing@vivo.com>

    [ Upstream commit 72f1aa6205d84337b90b065f602a8fe190821781 ]

    Fix following coccicheck warning:

    ./drivers/soc/qcom/apr.c:485:1-23: WARNING: Function
    for_each_child_of_node should have of_node_put() before return

    Early exits from for_each_child_of_node should decrement the
    node reference counter.

    Fixes: 834735662602 ("soc: qcom: apr: Add avs/audio tracking functionality")
    Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
    Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
    Link: https://lore.kernel.org/r/20211014083017.19714-1-wanjiabing@vivo.com
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/soc/qcom/apr.c | 2 ++
    1 file changed, 2 insertions(+)

    diff --git a/drivers/soc/qcom/apr.c b/drivers/soc/qcom/apr.c
    index 7abfc8c4fdc72..f736d208362c9 100644
    --- a/drivers/soc/qcom/apr.c
    +++ b/drivers/soc/qcom/apr.c
    @@ -323,12 +323,14 @@ static int of_apr_add_pd_lookups(struct device *dev)
    1, &service_path);
    if (ret < 0) {
    dev_err(dev, "pdr service path missing: %d\n", ret);
    + of_node_put(node);
    return ret;
    }

    pds = pdr_add_lookup(apr->pdr, service_name, service_path);
    if (IS_ERR(pds) && PTR_ERR(pds) != -EALREADY) {
    dev_err(dev, "pdr add lookup failed: %ld\n", PTR_ERR(pds));
    + of_node_put(node);
    return PTR_ERR(pds);
    }
    }
    --
    2.33.0


    \
     
     \ /
      Last update: 2021-11-16 02:40    [W:4.039 / U:0.632 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site