lkml.org 
[lkml]   [2021]   [Nov]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.14 687/849] Input: st1232 - increase "wait ready" timeout
    Date
    From: John Keeping <john@metanate.com>

    [ Upstream commit 2667f6b7af99e81958fa97c03bb519fcb09d0055 ]

    I have a ST1633 touch controller which fails to probe due to a timeout
    waiting for the controller to become ready. Increasing the minimum
    delay to 100ms ensures that the probe sequence completes successfully.

    The ST1633 datasheet says nothing about the maximum delay here and the
    ST1232 I2C protocol document says "wait until" with no notion of a
    timeout.

    Since this only runs once during probe, being generous with the timout
    seems reasonable and most likely the device will become ready
    eventually.

    (It may be worth noting that I saw this issue with a PREEMPT_RT patched
    kernel which probably has tighter wakeups from usleep_range() than other
    preemption models.)

    Fixes: f605be6a57b4 ("Input: st1232 - wait until device is ready before reading resolution")
    Signed-off-by: John Keeping <john@metanate.com>
    Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
    Link: https://lore.kernel.org/r/20210929152609.2421483-1-john@metanate.com
    Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/input/touchscreen/st1232.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/input/touchscreen/st1232.c b/drivers/input/touchscreen/st1232.c
    index 6abae665ca71d..9d1dea6996a22 100644
    --- a/drivers/input/touchscreen/st1232.c
    +++ b/drivers/input/touchscreen/st1232.c
    @@ -92,7 +92,7 @@ static int st1232_ts_wait_ready(struct st1232_ts_data *ts)
    unsigned int retries;
    int error;

    - for (retries = 10; retries; retries--) {
    + for (retries = 100; retries; retries--) {
    error = st1232_ts_read_data(ts, REG_STATUS, 1);
    if (!error) {
    switch (ts->read_buf[0]) {
    --
    2.33.0


    \
     
     \ /
      Last update: 2021-11-16 02:40    [W:2.974 / U:0.140 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site