lkml.org 
[lkml]   [2021]   [Nov]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.15 008/917] scsi: scsi_ioctl: Validate command size
    Date
    From: Tadeusz Struk <tadeusz.struk@linaro.org>

    commit 20aaef52eb08f1d987d46ad26edb8f142f74d83a upstream.

    Need to make sure the command size is valid before copying the command from
    user space.

    Link: https://lore.kernel.org/r/20211103170659.22151-1-tadeusz.struk@linaro.org
    Cc: Bart Van Assche <bvanassche@acm.org>
    Cc: Christoph Hellwig <hch@lst.de>
    Cc: James E.J. Bottomley <jejb@linux.ibm.com>
    Cc: Martin K. Petersen <martin.petersen@oracle.com>
    Cc: <linux-scsi@vger.kernel.org>
    Cc: <linux-kernel@vger.kernel.org>
    Cc: <stable@vger.kernel.org> # 5.15, 5.14, 5.10
    Signed-off-by: Tadeusz Struk <tadeusz.struk@linaro.org>
    Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/scsi/scsi_ioctl.c | 2 ++
    1 file changed, 2 insertions(+)

    --- a/drivers/scsi/scsi_ioctl.c
    +++ b/drivers/scsi/scsi_ioctl.c
    @@ -347,6 +347,8 @@ static int scsi_fill_sghdr_rq(struct scs
    {
    struct scsi_request *req = scsi_req(rq);

    + if (hdr->cmd_len < 6)
    + return -EMSGSIZE;
    if (copy_from_user(req->cmd, hdr->cmdp, hdr->cmd_len))
    return -EFAULT;
    if (!scsi_cmd_allowed(req->cmd, mode))

    \
     
     \ /
      Last update: 2021-11-16 02:40    [W:2.483 / U:0.364 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site