lkml.org 
[lkml]   [2021]   [Nov]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.14 610/849] pinctrl: renesas: checker: Fix off-by-one bug in drive register check
    Date
    From: Geert Uytterhoeven <geert+renesas@glider.be>

    [ Upstream commit 28e7f8ff90583791a034d43b5d2e3fe394142e13 ]

    The GENMASK(h, l) macro creates a contiguous bitmask starting at bit
    position @l and ending at position @h, inclusive.

    This did not trigger any error checks, as the individual register fields
    cover at most 3 of the 4 available bits.

    Fixes: 08df16e07ad0a1ec ("pinctrl: sh-pfc: checker: Add drive strength register checks")
    Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
    Link: https://lore.kernel.org/r/8f82d6147fbe3367d4c83962480e97f58d9c96a2.1633615652.git.geert+renesas@glider.be
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/pinctrl/renesas/core.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/pinctrl/renesas/core.c b/drivers/pinctrl/renesas/core.c
    index 5ccc49b387f17..77d1dc0f5b9ba 100644
    --- a/drivers/pinctrl/renesas/core.c
    +++ b/drivers/pinctrl/renesas/core.c
    @@ -886,7 +886,7 @@ static void __init sh_pfc_check_drive_reg(const struct sh_pfc_soc_info *info,
    if (!field->pin && !field->offset && !field->size)
    continue;

    - mask = GENMASK(field->offset + field->size, field->offset);
    + mask = GENMASK(field->offset + field->size - 1, field->offset);
    if (mask & seen)
    sh_pfc_err("drive_reg 0x%x: field %u overlap\n",
    drive->reg, i);
    --
    2.33.0


    \
     
     \ /
      Last update: 2021-11-16 02:40    [W:3.032 / U:0.412 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site