lkml.org 
[lkml]   [2021]   [Nov]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.14 742/849] mfd: core: Add missing of_node_put for loop iteration
    Date
    From: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>

    [ Upstream commit 002be81140075e17a1ebd5c3c55e356fbab0ddad ]

    Early exits from for_each_child_of_node() should decrement the
    node reference counter. Reported by Coccinelle:

    drivers/mfd/mfd-core.c:197:2-24: WARNING:
    Function "for_each_child_of_node" should have of_node_put() before goto around lines 209.

    Fixes: c94bb233a9fe ("mfd: Make MFD core code Device Tree and IRQ domain aware")
    Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
    Signed-off-by: Lee Jones <lee.jones@linaro.org>
    Link: https://lore.kernel.org/r/20210528115126.18370-1-krzysztof.kozlowski@canonical.com
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/mfd/mfd-core.c | 2 ++
    1 file changed, 2 insertions(+)

    diff --git a/drivers/mfd/mfd-core.c b/drivers/mfd/mfd-core.c
    index 79f5c6a18815a..684a011a63968 100644
    --- a/drivers/mfd/mfd-core.c
    +++ b/drivers/mfd/mfd-core.c
    @@ -198,6 +198,7 @@ static int mfd_add_device(struct device *parent, int id,
    if (of_device_is_compatible(np, cell->of_compatible)) {
    /* Ignore 'disabled' devices error free */
    if (!of_device_is_available(np)) {
    + of_node_put(np);
    ret = 0;
    goto fail_alias;
    }
    @@ -205,6 +206,7 @@ static int mfd_add_device(struct device *parent, int id,
    ret = mfd_match_of_node_to_dev(pdev, np, cell);
    if (ret == -EAGAIN)
    continue;
    + of_node_put(np);
    if (ret)
    goto fail_alias;

    --
    2.33.0


    \
     
     \ /
      Last update: 2021-11-16 02:40    [W:3.756 / U:0.164 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site