lkml.org 
[lkml]   [2021]   [Nov]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.14 304/849] selftests/bpf: Fix perf_buffer test on system with offline cpus
    Date
    From: Jiri Olsa <jolsa@redhat.com>

    [ Upstream commit d4121376ac7a9c81a696d7558789b2f29ef3574e ]

    The perf_buffer fails on system with offline cpus:

    # test_progs -t perf_buffer
    test_perf_buffer:PASS:nr_cpus 0 nsec
    test_perf_buffer:PASS:nr_on_cpus 0 nsec
    test_perf_buffer:PASS:skel_load 0 nsec
    test_perf_buffer:PASS:attach_kprobe 0 nsec
    test_perf_buffer:PASS:perf_buf__new 0 nsec
    test_perf_buffer:PASS:epoll_fd 0 nsec
    skipping offline CPU #24
    skipping offline CPU #25
    skipping offline CPU #26
    skipping offline CPU #27
    skipping offline CPU #28
    skipping offline CPU #29
    skipping offline CPU #30
    skipping offline CPU #31
    test_perf_buffer:PASS:perf_buffer__poll 0 nsec
    test_perf_buffer:PASS:seen_cpu_cnt 0 nsec
    test_perf_buffer:FAIL:buf_cnt got 24, expected 32
    Summary: 0/0 PASSED, 0 SKIPPED, 1 FAILED

    Changing the test to check online cpus instead of possible.

    Signed-off-by: Jiri Olsa <jolsa@kernel.org>
    Signed-off-by: Andrii Nakryiko <andrii@kernel.org>
    Acked-by: John Fastabend <john.fastabend@gmail.com>
    Link: https://lore.kernel.org/bpf/20211021114132.8196-2-jolsa@kernel.org
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    tools/testing/selftests/bpf/prog_tests/perf_buffer.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    diff --git a/tools/testing/selftests/bpf/prog_tests/perf_buffer.c b/tools/testing/selftests/bpf/prog_tests/perf_buffer.c
    index 6490e9673002f..7daaaab13681b 100644
    --- a/tools/testing/selftests/bpf/prog_tests/perf_buffer.c
    +++ b/tools/testing/selftests/bpf/prog_tests/perf_buffer.c
    @@ -107,8 +107,8 @@ void test_perf_buffer(void)
    "expect %d, seen %d\n", nr_on_cpus, CPU_COUNT(&cpu_seen)))
    goto out_free_pb;

    - if (CHECK(perf_buffer__buffer_cnt(pb) != nr_cpus, "buf_cnt",
    - "got %zu, expected %d\n", perf_buffer__buffer_cnt(pb), nr_cpus))
    + if (CHECK(perf_buffer__buffer_cnt(pb) != nr_on_cpus, "buf_cnt",
    + "got %zu, expected %d\n", perf_buffer__buffer_cnt(pb), nr_on_cpus))
    goto out_close;

    for (i = 0; i < nr_cpus; i++) {
    --
    2.33.0


    \
     
     \ /
      Last update: 2021-11-16 02:40    [W:4.726 / U:0.060 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site