lkml.org 
[lkml]   [2021]   [Nov]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] powerpc/book3e: Fix TLBCAM preset at boot
From
Date
On 15 November 2021 at 10:05 am, Christophe Leroy wrote:
> Commit 52bda69ae8b5 ("powerpc/fsl_booke: Tell map_mem_in_cams() if
> init is done") was supposed to just add an additional parameter to
> map_mem_in_cams() and always set it to 'true' at that time.
>
> But a few call sites were messed up. Fix them.
>
> Reported-by: Christian Zigotzky <chzigotzky@xenosoft.de>
> Fixes: 52bda69ae8b5 ("powerpc/fsl_booke: Tell map_mem_in_cams() if init is done")
> Signed-off-by: Christophe Leroy <christophe.leroy@csgroup.eu>
> ---
> arch/powerpc/mm/nohash/kaslr_booke.c | 2 +-
> arch/powerpc/mm/nohash/tlb.c | 4 ++--
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/powerpc/mm/nohash/kaslr_booke.c b/arch/powerpc/mm/nohash/kaslr_booke.c
> index 8fc49b1b4a91..6ec978967da0 100644
> --- a/arch/powerpc/mm/nohash/kaslr_booke.c
> +++ b/arch/powerpc/mm/nohash/kaslr_booke.c
> @@ -314,7 +314,7 @@ static unsigned long __init kaslr_choose_location(void *dt_ptr, phys_addr_t size
> pr_warn("KASLR: No safe seed for randomizing the kernel base.\n");
>
> ram = min_t(phys_addr_t, __max_low_memory, size);
> - ram = map_mem_in_cams(ram, CONFIG_LOWMEM_CAM_NUM, true, false);
> + ram = map_mem_in_cams(ram, CONFIG_LOWMEM_CAM_NUM, true, true);
> linear_sz = min_t(unsigned long, ram, SZ_512M);
>
> /* If the linear size is smaller than 64M, do not randmize */
> diff --git a/arch/powerpc/mm/nohash/tlb.c b/arch/powerpc/mm/nohash/tlb.c
> index 89353d4f5604..647bf454a0fa 100644
> --- a/arch/powerpc/mm/nohash/tlb.c
> +++ b/arch/powerpc/mm/nohash/tlb.c
> @@ -645,7 +645,7 @@ static void early_init_this_mmu(void)
>
> if (map)
> linear_map_top = map_mem_in_cams(linear_map_top,
> - num_cams, true, true);
> + num_cams, false, true);
> }
> #endif
>
> @@ -766,7 +766,7 @@ void setup_initial_memory_limit(phys_addr_t first_memblock_base,
> num_cams = (mfspr(SPRN_TLB1CFG) & TLBnCFG_N_ENTRY) / 4;
>
> linear_sz = map_mem_in_cams(first_memblock_size, num_cams,
> - false, true);
> + true, true);
>
> ppc64_rma_size = min_t(u64, linear_sz, 0x40000000);
> } else
Tested-by: Christian Zigotzky <chzigotzky@xenosoft.de>

Thanks

\
 
 \ /
  Last update: 2021-11-15 12:17    [W:0.130 / U:0.012 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site