lkml.org 
[lkml]   [2021]   [Nov]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.14 411/849] crypto: ccree - avoid out-of-range warnings from clang
    Date
    From: Arnd Bergmann <arnd@arndb.de>

    [ Upstream commit cfd6fb45cfaf46fa9547421d8da387dc9c7997d4 ]

    clang points out inconsistencies in the FIELD_PREP() invocation in
    this driver that result from the 'mask' being a 32-bit value:

    drivers/crypto/ccree/cc_driver.c:117:18: error: result of comparison of constant 18446744073709551615 with expression of type 'u32' (aka 'unsigned int') is always false [-Werror,-Wtautological-constant-out-of-range-compare]
    cache_params |= FIELD_PREP(mask, val);
    ^~~~~~~~~~~~~~~~~~~~~
    include/linux/bitfield.h:94:3: note: expanded from macro 'FIELD_PREP'
    __BF_FIELD_CHECK(_mask, 0ULL, _val, "FIELD_PREP: "); \
    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    include/linux/bitfield.h:52:28: note: expanded from macro '__BF_FIELD_CHECK'
    BUILD_BUG_ON_MSG((_mask) > (typeof(_reg))~0ull, \
    ~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

    This does not happen in other places that just pass a constant here.

    Work around the warnings by widening the type of the temporary variable.

    Fixes: 05c2a705917b ("crypto: ccree - rework cache parameters handling")
    Signed-off-by: Arnd Bergmann <arnd@arndb.de>
    Acked-by: Gilad ben-Yossef <gilad@benyossef.com>
    Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/crypto/ccree/cc_driver.c | 3 ++-
    1 file changed, 2 insertions(+), 1 deletion(-)

    diff --git a/drivers/crypto/ccree/cc_driver.c b/drivers/crypto/ccree/cc_driver.c
    index e599ac6dc162a..790fa9058a36d 100644
    --- a/drivers/crypto/ccree/cc_driver.c
    +++ b/drivers/crypto/ccree/cc_driver.c
    @@ -103,7 +103,8 @@ MODULE_DEVICE_TABLE(of, arm_ccree_dev_of_match);
    static void init_cc_cache_params(struct cc_drvdata *drvdata)
    {
    struct device *dev = drvdata_to_dev(drvdata);
    - u32 cache_params, ace_const, val, mask;
    + u32 cache_params, ace_const, val;
    + u64 mask;

    /* compute CC_AXIM_CACHE_PARAMS */
    cache_params = cc_ioread(drvdata, CC_REG(AXIM_CACHE_PARAMS));
    --
    2.33.0


    \
     
     \ /
      Last update: 2021-11-16 02:38    [W:4.054 / U:0.164 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site