lkml.org 
[lkml]   [2021]   [Nov]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.14 251/849] media: mceusb: return without resubmitting URB in case of -EPROTO error.
    Date
    From: Rajat Asthana <rajatasthana4@gmail.com>

    [ Upstream commit 476db72e521983ecb847e4013b263072bb1110fc ]

    Syzkaller reported a warning called "rcu detected stall in dummy_timer".

    The error seems to be an error in mceusb_dev_recv(). In the case of
    -EPROTO error, the routine immediately resubmits the URB. Instead it
    should return without resubmitting URB.

    Reported-by: syzbot+4d3749e9612c2cfab956@syzkaller.appspotmail.com
    Signed-off-by: Rajat Asthana <rajatasthana4@gmail.com>
    Signed-off-by: Sean Young <sean@mess.org>
    Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/media/rc/mceusb.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/drivers/media/rc/mceusb.c b/drivers/media/rc/mceusb.c
    index 5642595a057ec..8870c4e6c5f44 100644
    --- a/drivers/media/rc/mceusb.c
    +++ b/drivers/media/rc/mceusb.c
    @@ -1386,6 +1386,7 @@ static void mceusb_dev_recv(struct urb *urb)
    case -ECONNRESET:
    case -ENOENT:
    case -EILSEQ:
    + case -EPROTO:
    case -ESHUTDOWN:
    usb_unlink_urb(urb);
    return;
    --
    2.33.0


    \
     
     \ /
      Last update: 2021-11-16 02:36    [W:2.430 / U:0.212 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site