lkml.org 
[lkml]   [2021]   [Nov]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.14 594/849] clk: at91: check pmc node status before registering syscore ops
    Date
    From: Clément Léger <clement.leger@bootlin.com>

    [ Upstream commit c405f5c15e9f6094f2fa1658e73e56f3058e2122 ]

    Currently, at91 pmc driver always register the syscore_ops whatever
    the status of the pmc node that has been found. When set as secure
    and disabled, the pmc should not be accessed or this will generate
    abort exceptions.
    To avoid this, add a check on node availability before registering
    the syscore operations.

    Signed-off-by: Clément Léger <clement.leger@bootlin.com>
    Link: https://lore.kernel.org/r/20210913082633.110168-1-clement.leger@bootlin.com
    Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>
    Reviewed-by: Claudiu Beznea <claudiu.beznea@microchip.com>
    Fixes: b3b02eac33ed ("clk: at91: Add sama5d2 suspend/resume")
    Signed-off-by: Stephen Boyd <sboyd@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/clk/at91/pmc.c | 5 +++++
    1 file changed, 5 insertions(+)

    diff --git a/drivers/clk/at91/pmc.c b/drivers/clk/at91/pmc.c
    index 20ee9dccee787..b40035b011d0a 100644
    --- a/drivers/clk/at91/pmc.c
    +++ b/drivers/clk/at91/pmc.c
    @@ -267,6 +267,11 @@ static int __init pmc_register_ops(void)
    if (!np)
    return -ENODEV;

    + if (!of_device_is_available(np)) {
    + of_node_put(np);
    + return -ENODEV;
    + }
    +
    pmcreg = device_node_to_regmap(np);
    of_node_put(np);
    if (IS_ERR(pmcreg))
    --
    2.33.0


    \
     
     \ /
      Last update: 2021-11-16 02:25    [W:4.343 / U:0.560 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site