lkml.org 
[lkml]   [2021]   [Nov]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.14 670/849] rtc: pcf2123: Add SPI ID table
    Date
    From: Mark Brown <broonie@kernel.org>

    [ Upstream commit 5f84478e14aa8b43a4ea85d2e091931741947749 ]

    Currently autoloading for SPI devices does not use the DT ID table, it uses
    SPI modalises. Supporting OF modalises is going to be difficult if not
    impractical, an attempt was made but has been reverted, so ensure that
    module autoloading works for this driver by adding an id_table listing the
    SPI IDs for everything.

    Fixes: 96c8395e2166 ("spi: Revert modalias changes")
    Signed-off-by: Mark Brown <broonie@kernel.org>
    Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
    Link: https://lore.kernel.org/r/20210923194922.53386-4-broonie@kernel.org
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/rtc/rtc-pcf2123.c | 9 +++++++++
    1 file changed, 9 insertions(+)

    diff --git a/drivers/rtc/rtc-pcf2123.c b/drivers/rtc/rtc-pcf2123.c
    index 0f58cac81d8c0..7473e6c8a183b 100644
    --- a/drivers/rtc/rtc-pcf2123.c
    +++ b/drivers/rtc/rtc-pcf2123.c
    @@ -451,12 +451,21 @@ static const struct of_device_id pcf2123_dt_ids[] = {
    MODULE_DEVICE_TABLE(of, pcf2123_dt_ids);
    #endif

    +static const struct spi_device_id pcf2123_spi_ids[] = {
    + { .name = "pcf2123", },
    + { .name = "rv2123", },
    + { .name = "rtc-pcf2123", },
    + { /* sentinel */ }
    +};
    +MODULE_DEVICE_TABLE(spi, pcf2123_spi_ids);
    +
    static struct spi_driver pcf2123_driver = {
    .driver = {
    .name = "rtc-pcf2123",
    .of_match_table = of_match_ptr(pcf2123_dt_ids),
    },
    .probe = pcf2123_probe,
    + .id_table = pcf2123_spi_ids,
    };

    module_spi_driver(pcf2123_driver);
    --
    2.33.0


    \
     
     \ /
      Last update: 2021-11-16 02:20    [W:4.103 / U:0.624 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site