lkml.org 
[lkml]   [2021]   [Nov]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.15 062/917] btrfs: fix lost error handling when replaying directory deletes
    Date
    From: Filipe Manana <fdmanana@suse.com>

    commit 10adb1152d957a4d570ad630f93a88bb961616c1 upstream.

    At replay_dir_deletes(), if find_dir_range() returns an error we break out
    of the main while loop and then assign a value of 0 (success) to the 'ret'
    variable, resulting in completely ignoring that an error happened. Fix
    that by jumping to the 'out' label when find_dir_range() returns an error
    (negative value).

    CC: stable@vger.kernel.org # 4.4+
    Reviewed-by: Josef Bacik <josef@toxicpanda.com>
    Signed-off-by: Filipe Manana <fdmanana@suse.com>
    Signed-off-by: David Sterba <dsterba@suse.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    fs/btrfs/tree-log.c | 4 +++-
    1 file changed, 3 insertions(+), 1 deletion(-)

    --- a/fs/btrfs/tree-log.c
    +++ b/fs/btrfs/tree-log.c
    @@ -2500,7 +2500,9 @@ again:
    else {
    ret = find_dir_range(log, path, dirid, key_type,
    &range_start, &range_end);
    - if (ret != 0)
    + if (ret < 0)
    + goto out;
    + else if (ret > 0)
    break;
    }


    \
     
     \ /
      Last update: 2021-11-16 02:11    [W:4.133 / U:0.116 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site