lkml.org 
[lkml]   [2021]   [Nov]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.15 633/917] dyndbg: make dyndbg a known cli param
    Date
    From: Andrew Halaney <ahalaney@redhat.com>

    [ Upstream commit 5ca173974888368fecfb17ae6fe455df5fd2a9d2 ]

    Right now dyndbg shows up as an unknown parameter if used on boot:

    Unknown command line parameters: dyndbg=+p

    That's because it is unknown, it doesn't sit in the __param
    section, so the processing done to warn users supplying an unknown
    parameter doesn't think it is legitimate.

    Install a dummy handler to register it. dynamic debug needs to search
    the whole command line for modules listed that are currently builtin,
    so there's no real work to be done in this callback.

    Fixes: 86d1919a4fb0 ("init: print out unknown kernel parameters")
    Tested-by: Jim Cromie <jim.cromie@gmail.com>
    Signed-off-by: Andrew Halaney <ahalaney@redhat.com>
    Signed-off-by: Jason Baron <jbaron@akamai.com>
    Link: https://lore.kernel.org/r/1634139622-20667-2-git-send-email-jbaron@akamai.com
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    lib/dynamic_debug.c | 12 ++++++++++++
    1 file changed, 12 insertions(+)

    diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c
    index cb5abb42c16a2..84c16309cc637 100644
    --- a/lib/dynamic_debug.c
    +++ b/lib/dynamic_debug.c
    @@ -761,6 +761,18 @@ static __init int ddebug_setup_query(char *str)

    __setup("ddebug_query=", ddebug_setup_query);

    +/*
    + * Install a noop handler to make dyndbg look like a normal kernel cli param.
    + * This avoids warnings about dyndbg being an unknown cli param when supplied
    + * by a user.
    + */
    +static __init int dyndbg_setup(char *str)
    +{
    + return 1;
    +}
    +
    +__setup("dyndbg=", dyndbg_setup);
    +
    /*
    * File_ops->write method for <debugfs>/dynamic_debug/control. Gathers the
    * command text from userspace, parses and executes it.
    --
    2.33.0


    \
     
     \ /
      Last update: 2021-11-16 02:11    [W:4.024 / U:0.520 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site