lkml.org 
[lkml]   [2021]   [Nov]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.15 721/917] mtd: spi-nor: hisi-sfc: Remove excessive clk_disable_unprepare()
    Date
    From: Evgeny Novikov <novikov@ispras.ru>

    [ Upstream commit 78e4d342187625585932bb437ec26e1060f7fc6f ]

    hisi_spi_nor_probe() invokes clk_disable_unprepare() on all paths after
    successful call of clk_prepare_enable(). Besides, the clock is enabled by
    hispi_spi_nor_prep() and disabled by hispi_spi_nor_unprep(). So at remove
    time it is not possible to have the clock enabled. The patch removes
    excessive clk_disable_unprepare() from hisi_spi_nor_remove().

    Found by Linux Driver Verification project (linuxtesting.org).

    Fixes: e523f11141bd ("mtd: spi-nor: add hisilicon spi-nor flash controller driver")
    Signed-off-by: Evgeny Novikov <novikov@ispras.ru>
    Signed-off-by: Tudor Ambarus <tudor.ambarus@microchip.com>
    Reviewed-by: Pratyush Yadav <p.yadav@ti.com>
    Link: https://lore.kernel.org/r/20210709144529.31379-1-novikov@ispras.ru
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/mtd/spi-nor/controllers/hisi-sfc.c | 1 -
    1 file changed, 1 deletion(-)

    diff --git a/drivers/mtd/spi-nor/controllers/hisi-sfc.c b/drivers/mtd/spi-nor/controllers/hisi-sfc.c
    index 47fbf1d1e5573..516e502694780 100644
    --- a/drivers/mtd/spi-nor/controllers/hisi-sfc.c
    +++ b/drivers/mtd/spi-nor/controllers/hisi-sfc.c
    @@ -477,7 +477,6 @@ static int hisi_spi_nor_remove(struct platform_device *pdev)

    hisi_spi_nor_unregister_all(host);
    mutex_destroy(&host->lock);
    - clk_disable_unprepare(host->clk);
    return 0;
    }

    --
    2.33.0


    \
     
     \ /
      Last update: 2021-11-16 02:11    [W:2.217 / U:0.748 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site