lkml.org 
[lkml]   [2021]   [Nov]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.15 697/917] rtc: ds1302: Add SPI ID table
    Date
    From: Mark Brown <broonie@kernel.org>

    [ Upstream commit 8719a17613e0233d707eb22e1645d217594631ef ]

    Currently autoloading for SPI devices does not use the DT ID table, it uses
    SPI modalises. Supporting OF modalises is going to be difficult if not
    impractical, an attempt was made but has been reverted, so ensure that
    module autoloading works for this driver by adding an id_table listing the
    SPI IDs for everything.

    Fixes: 96c8395e2166 ("spi: Revert modalias changes")
    Signed-off-by: Mark Brown <broonie@kernel.org>
    Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
    Link: https://lore.kernel.org/r/20210923194922.53386-2-broonie@kernel.org
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/rtc/rtc-ds1302.c | 7 +++++++
    1 file changed, 7 insertions(+)

    diff --git a/drivers/rtc/rtc-ds1302.c b/drivers/rtc/rtc-ds1302.c
    index b3de6d2e680a4..2f83adef966eb 100644
    --- a/drivers/rtc/rtc-ds1302.c
    +++ b/drivers/rtc/rtc-ds1302.c
    @@ -199,11 +199,18 @@ static const struct of_device_id ds1302_dt_ids[] = {
    MODULE_DEVICE_TABLE(of, ds1302_dt_ids);
    #endif

    +static const struct spi_device_id ds1302_spi_ids[] = {
    + { .name = "ds1302", },
    + { /* sentinel */ }
    +};
    +MODULE_DEVICE_TABLE(spi, ds1302_spi_ids);
    +
    static struct spi_driver ds1302_driver = {
    .driver.name = "rtc-ds1302",
    .driver.of_match_table = of_match_ptr(ds1302_dt_ids),
    .probe = ds1302_probe,
    .remove = ds1302_remove,
    + .id_table = ds1302_spi_ids,
    };

    module_spi_driver(ds1302_driver);
    --
    2.33.0


    \
     
     \ /
      Last update: 2021-11-16 02:11    [W:2.269 / U:2.508 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site