lkml.org 
[lkml]   [2021]   [Nov]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.15 759/917] xen-pciback: Fix return in pm_ctrl_init()
    Date
    From: YueHaibing <yuehaibing@huawei.com>

    [ Upstream commit 4745ea2628bb43a7ec34b71763b5a56407b33990 ]

    Return NULL instead of passing to ERR_PTR while err is zero,
    this fix smatch warnings:
    drivers/xen/xen-pciback/conf_space_capability.c:163
    pm_ctrl_init() warn: passing zero to 'ERR_PTR'

    Fixes: a92336a1176b ("xen/pciback: Drop two backends, squash and cleanup some code.")
    Signed-off-by: YueHaibing <yuehaibing@huawei.com>
    Reviewed-by: Juergen Gross <jgross@suse.com>
    Link: https://lore.kernel.org/r/20211008074417.8260-1-yuehaibing@huawei.com
    Signed-off-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/xen/xen-pciback/conf_space_capability.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/xen/xen-pciback/conf_space_capability.c b/drivers/xen/xen-pciback/conf_space_capability.c
    index 22f13abbe9130..5e53b4817f167 100644
    --- a/drivers/xen/xen-pciback/conf_space_capability.c
    +++ b/drivers/xen/xen-pciback/conf_space_capability.c
    @@ -160,7 +160,7 @@ static void *pm_ctrl_init(struct pci_dev *dev, int offset)
    }

    out:
    - return ERR_PTR(err);
    + return err ? ERR_PTR(err) : NULL;
    }

    static const struct config_field caplist_pm[] = {
    --
    2.33.0


    \
     
     \ /
      Last update: 2021-11-16 02:10    [W:2.323 / U:0.148 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site