lkml.org 
[lkml]   [2021]   [Nov]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.15 686/917] ASoC: rsnd: Fix an error handling path in rsnd_node_count()
    Date
    From: Christophe JAILLET <christophe.jaillet@wanadoo.fr>

    [ Upstream commit 173632358fde7a567f28e07c4549b959ee857986 ]

    If we return before the end of the 'for_each_child_of_node()' iterator, the
    reference taken on 'np' must be released.

    Add the missing 'of_node_put()' call.

    Fixes: c413983eb66a ("ASoC: rsnd: adjust disabled module")
    Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
    Reviewed-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
    Link: https://lore.kernel.org/r/4c0e893cbfa21dc76c1ede0b6f4f8cff42209299.1634586167.git.christophe.jaillet@wanadoo.fr
    Signed-off-by: Mark Brown <broonie@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    sound/soc/sh/rcar/core.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/sound/soc/sh/rcar/core.c b/sound/soc/sh/rcar/core.c
    index 978bd0406729a..6a8fe0da7670b 100644
    --- a/sound/soc/sh/rcar/core.c
    +++ b/sound/soc/sh/rcar/core.c
    @@ -1225,6 +1225,7 @@ int rsnd_node_count(struct rsnd_priv *priv, struct device_node *node, char *name
    if (i < 0) {
    dev_err(dev, "strange node numbering (%s)",
    of_node_full_name(node));
    + of_node_put(np);
    return 0;
    }
    i++;
    --
    2.33.0


    \
     
     \ /
      Last update: 2021-11-16 02:10    [W:4.385 / U:1.472 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site