lkml.org 
[lkml]   [2021]   [Nov]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Subject[PATCH v3 0/8] staging: vt6655: Fix line wrapping in `RFvWriteWakeProgSyn`
Date
This patch set is a series of small refactorings of the function
`RFvWriteWakeProgSyn`, now renamed to `rf_write_wake_prog_syn`.
The work here allowed to shorten lines marked by checkpatch.pl as
being too long by:
* introducing two new temporary variables (`idx` and `init_table`)
* rewriting a conditional to switch between two modes of
AL7320 initialization.

In addition to this, the patch set renames the function to align it with
the kernel coding style, updates the function description and removes two
unnecessary conditionals checking if the value of `init_count` is lower than
a predefined value.


Changes in v3:
* add a patch for removing the type cast as a first change, suggested by
Dan Carpenter <dan.carpenter@oracle.com>
* merge two patches (using incrementation in `idx` and cleanup) into one,
partially implementing Dan's suggestion

Changes in v2:
* drop "staging: vt6655: Introduce `data` temporary variable" patch, suggested
by Julia Lawall <julia.lawall@inria.fr>
* amend "staging: vt6655: Rewrite conditional in AL7320 initialization" patch
to use indexing and `init_table` temporary variable
* add two new patches to remove unnecessary checks for init count, suggested
by Mike Rapoport <mike.rapoport@gmail.com>:
- "staging: vt6655: Delete bogus check for `init_count` in AL2230"
- "staging: vt6655: Delete bogus check for `init_count` in AL7230"

Karolina Drobnik (8):
staging: vt6655: Remove unnecessary type casts
staging: vt6655: Introduce `idx` variable
staging: vt6655: Use incrementation in `idx`
staging: vt6655: Rewrite conditional in AL7320 initialization
staging: vt6655: Rename `RFvWriteWakeProgSyn` function
staging: vt6655: Update comment for `rf_write_wake_prog_syn`
staging: vt6655: Delete bogus check for `init_count` in AL2230
staging: vt6655: Delete bogus check for `init_count` in AL7230

drivers/staging/vt6655/channel.c | 2 +-
drivers/staging/vt6655/rf.c | 44 +++++++++++++-------------------
drivers/staging/vt6655/rf.h | 2 +-
3 files changed, 20 insertions(+), 28 deletions(-)

--
2.30.2

\
 
 \ /
  Last update: 2021-11-15 11:57    [W:0.062 / U:0.060 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site