lkml.org 
[lkml]   [2021]   [Nov]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.15 103/917] perf/x86/intel/uncore: Fix invalid unit check
    Date
    From: Kan Liang <kan.liang@linux.intel.com>

    commit e2bb9fab08cbcc7922050c7eb0bd650807abfa4e upstream.

    The uncore unit with the type ID 0 and the unit ID 0 is missed.

    The table3 of the uncore unit maybe 0. The
    uncore_discovery_invalid_unit() mistakenly treated it as an invalid
    value.

    Remove the !unit.table3 check.

    Fixes: edae1f06c2cd ("perf/x86/intel/uncore: Parse uncore discovery tables")
    Signed-off-by: Kan Liang <kan.liang@linux.intel.com>
    Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
    Reviewed-by: Andi Kleen <ak@linux.intel.com>
    Cc: stable@vger.kernel.org
    Link: https://lkml.kernel.org/r/1629991963-102621-3-git-send-email-kan.liang@linux.intel.com
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    arch/x86/events/intel/uncore_discovery.h | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/arch/x86/events/intel/uncore_discovery.h
    +++ b/arch/x86/events/intel/uncore_discovery.h
    @@ -30,7 +30,7 @@


    #define uncore_discovery_invalid_unit(unit) \
    - (!unit.table1 || !unit.ctl || !unit.table3 || \
    + (!unit.table1 || !unit.ctl || \
    unit.table1 == -1ULL || unit.ctl == -1ULL || \
    unit.table3 == -1ULL)


    \
     
     \ /
      Last update: 2021-11-16 02:10    [W:2.393 / U:0.620 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site