lkml.org 
[lkml]   [2021]   [Nov]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.15 296/917] tools/latency-collector: Use correct size when writing queue_full_warning
    Date
    From: Viktor Rosendahl <Viktor.Rosendahl@bmw.de>

    [ Upstream commit f604de20c0a47e0e9518940a1810193678c92fa8 ]

    queue_full_warning is a pointer, so it is wrong to use sizeof to calculate
    the number of characters of the string it points to. The effect is that we
    only print out the first few characters of the warning string.

    The correct way is to use strlen(). We don't need to add 1 to the strlen()
    because we don't want to write the terminating null character to stdout.

    Link: https://lkml.kernel.org/r/20211019160701.15587-1-Viktor.Rosendahl@bmw.de

    Link: https://lore.kernel.org/r/8fd4bb65ef3da67feac9ce3258cdbe9824752cf1.1629198502.git.jing.yangyang@zte.com.cn
    Link: https://lore.kernel.org/r/20211012025424.180781-1-davidcomponentone@gmail.com
    Reported-by: Zeal Robot <zealci@zte.com.cn>
    Signed-off-by: Viktor Rosendahl <Viktor.Rosendahl@bmw.de>
    Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    tools/tracing/latency/latency-collector.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/tools/tracing/latency/latency-collector.c b/tools/tracing/latency/latency-collector.c
    index 3a2e6bb781a8c..59a7f2346eab4 100644
    --- a/tools/tracing/latency/latency-collector.c
    +++ b/tools/tracing/latency/latency-collector.c
    @@ -1538,7 +1538,7 @@ static void tracing_loop(void)
    mutex_lock(&print_mtx);
    check_signals();
    write_or_die(fd_stdout, queue_full_warning,
    - sizeof(queue_full_warning));
    + strlen(queue_full_warning));
    mutex_unlock(&print_mtx);
    }
    modified--;
    --
    2.33.0


    \
     
     \ /
      Last update: 2021-11-16 01:59    [W:2.377 / U:0.732 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site