lkml.org 
[lkml]   [2021]   [Nov]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.15 852/917] MIPS: fix *-pkg builds for loongson2ef platform
    Date
    From: Masahiro Yamada <masahiroy@kernel.org>

    commit 0706f74f719e6e72c3a862ab2990796578fa73cc upstream.

    Since commit 805b2e1d427a ("kbuild: include Makefile.compiler only when
    compiler is needed"), package builds for the loongson2f platform fail.

    $ make ARCH=mips CROSS_COMPILE=mips64-linux- lemote2f_defconfig bindeb-pkg
    [ snip ]
    sh ./scripts/package/builddeb
    arch/mips/loongson2ef//Platform:36: *** only binutils >= 2.20.2 have needed option -mfix-loongson2f-nop. Stop.
    cp: cannot stat '': No such file or directory
    make[5]: *** [scripts/Makefile.package:87: intdeb-pkg] Error 1
    make[4]: *** [Makefile:1558: intdeb-pkg] Error 2
    make[3]: *** [debian/rules:13: binary-arch] Error 2
    dpkg-buildpackage: error: debian/rules binary subprocess returned exit status 2
    make[2]: *** [scripts/Makefile.package:83: bindeb-pkg] Error 2
    make[1]: *** [Makefile:1558: bindeb-pkg] Error 2
    make: *** [Makefile:350: __build_one_by_one] Error 2

    The reason is because "make image_name" fails.

    $ make ARCH=mips CROSS_COMPILE=mips64-linux- image_name
    arch/mips/loongson2ef//Platform:36: *** only binutils >= 2.20.2 have needed option -mfix-loongson2f-nop. Stop.

    In general, adding $(error ...) in the parse stage is troublesome,
    and it is pointless to check toolchains even if we are not building
    anything. Do not include Kbuild.platform in such cases.

    Fixes: 805b2e1d427a ("kbuild: include Makefile.compiler only when compiler is needed")
    Reported-by: Jason Self <jason@bluehome.net>
    Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
    Signed-off-by: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    arch/mips/Makefile | 2 ++
    1 file changed, 2 insertions(+)

    --- a/arch/mips/Makefile
    +++ b/arch/mips/Makefile
    @@ -254,7 +254,9 @@ endif
    #
    # Board-dependent options and extra files
    #
    +ifdef need-compiler
    include $(srctree)/arch/mips/Kbuild.platforms
    +endif

    ifdef CONFIG_PHYSICAL_START
    load-y = $(CONFIG_PHYSICAL_START)

    \
     
     \ /
      Last update: 2021-11-16 01:44    [W:4.186 / U:0.080 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site