lkml.org 
[lkml]   [2021]   [Nov]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.15 575/917] scsi: lpfc: Fix NVMe I/O failover to non-optimized path
    Date
    From: James Smart <jsmart2021@gmail.com>

    [ Upstream commit b507357f79171fb4fb4e732ca43a1f30bc5aab1d ]

    Currently, we hold off unregistering with NVMe transport layer until GID_FT
    or ADISC completes upon receipt of RSCN. In the ADISC discovery routine,
    for nodes not found in the GID_FT response, the nodes are unregistered from
    the SCSI transport but not UNREG_RPI'd. Meaning outstanding WQEs continue
    to be outstanding and were not failed back to the OS. If an NVMe device,
    this mean there wasn't initial termination of the I/Os so they could be
    issued on a different NVMe path.

    Fix by unregistering the RPI so that I/O is cancelled.

    Link: https://lore.kernel.org/r/20210910233159.115896-8-jsmart2021@gmail.com
    Fixes: 0614568361b0 ("scsi: lpfc: Delay unregistering from transport until GIDFT or ADISC completes")
    Co-developed-by: Justin Tee <justin.tee@broadcom.com>
    Signed-off-by: Justin Tee <justin.tee@broadcom.com>
    Signed-off-by: James Smart <jsmart2021@gmail.com>
    Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/scsi/lpfc/lpfc_els.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/drivers/scsi/lpfc/lpfc_els.c b/drivers/scsi/lpfc/lpfc_els.c
    index 0a68e565147a7..666b0a1b558ac 100644
    --- a/drivers/scsi/lpfc/lpfc_els.c
    +++ b/drivers/scsi/lpfc/lpfc_els.c
    @@ -6215,6 +6215,7 @@ lpfc_els_disc_adisc(struct lpfc_vport *vport)
    * from backend
    */
    lpfc_nlp_unreg_node(vport, ndlp);
    + lpfc_unreg_rpi(vport, ndlp);
    continue;
    }

    --
    2.33.0


    \
     
     \ /
      Last update: 2021-11-16 01:40    [W:4.016 / U:0.132 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site