lkml.org 
[lkml]   [2021]   [Nov]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.15 917/917] drm/amd/display: Look at firmware version to determine using dmub on dcn21
    Date
    From: Mario Limonciello <mario.limonciello@amd.com>

    commit 91adec9e07097e538691daed5d934e7886dd1dc3 upstream.

    commit 652de07addd2 ("drm/amd/display: Fully switch to dmub for all dcn21
    asics") switched over to using dmub on Renoir to fix Gitlab 1735, but this
    implied a new dependency on newer firmware which might not be met on older
    kernel versions.

    Since sw_init runs before hw_init, there is an opportunity to determine
    whether or not the firmware version is new to adjust the behavior.

    Cc: Roman.Li@amd.com
    BugLink: https://gitlab.freedesktop.org/drm/amd/-/issues/1772
    BugLink: https://gitlab.freedesktop.org/drm/amd/-/issues/1735
    Fixes: 652de07addd2 ("drm/amd/display: Fully switch to dmub for all dcn21 asics")
    Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
    Acked-by: Alex Deucher <alexander.deucher@amd.com>
    Reviewed-by: Roman Li <Roman.Li@amd.com>
    Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 9 ++++++++-
    1 file changed, 8 insertions(+), 1 deletion(-)

    --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
    +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
    @@ -1141,8 +1141,15 @@ static int amdgpu_dm_init(struct amdgpu_
    case CHIP_RAVEN:
    case CHIP_RENOIR:
    init_data.flags.gpu_vm_support = true;
    - if (ASICREV_IS_GREEN_SARDINE(adev->external_rev_id))
    + switch (adev->dm.dmcub_fw_version) {
    + case 0: /* development */
    + case 0x1: /* linux-firmware.git hash 6d9f399 */
    + case 0x01000000: /* linux-firmware.git hash 9a0b0f4 */
    + init_data.flags.disable_dmcu = false;
    + break;
    + default:
    init_data.flags.disable_dmcu = true;
    + }
    break;
    case CHIP_VANGOGH:
    case CHIP_YELLOW_CARP:

    \
     
     \ /
      Last update: 2021-11-16 01:40    [W:4.075 / U:0.828 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site